Hi James-
Good points, see below.
On 06/22/10 08:26 PM, James Morris wrote:
On Tue, 22 Jun 2010, Chuck Lever wrote:
Another place to look is at NFSv4. Some of the operations that can be
performed on NFSv4 xattrs are probably nearly what you would want for an NFSv3
implementation. I think it is desirable for anything done for NFSv3 to be
compatible with NFSv4, as that is already a standard.
Are you referring to named attributes? I've looked into this, as have
others, and they appear to be fundamentally incompatible with Linux/BSD
xattrs. They're filesystems within files, with different semantics to the
name/value string model that we use. I've heard a few developers say
they've looked at implementing xattrs over NAs, but found it unworkable.
There's the issue of namespacing -- named attributes have no structured
namespace, whereas, Linux/BSD xattrs use namespaces to denote semantics.
NAs are also intended to be managed at the user level without kernel
interaction, which conflicts with the semantics of our system namespaces.
In the past, I've seen several discussions on the issue conclude that
NFSv4 should have distinct Linux/BSD xattr OPs, although I don't know what
the current thinking is.
My thought was to extend NFSv4 to provide native xattr support alongside
named attribute support. If NFSv4 is getting security label support
then that's a moot point, unless there are other use cases for exposing
xattrs to NFS clients.
Overall, I think everyone is better off in the long run if we get the
needed features into NFSv4.
(Btw, slides from a presentation I did on this last year at LinuxCon are
at http://namei.org/presentations/linuxcon09_nfsv3xattrs.pdf)
NFSACL was added to our NFSv3 implementation because there was a desire to
interoperate with an existing (albeit nonstandard) implementation. Here you
are building a new side band protocol from scratch.
Well, it is implemented in IRIX -- I used their GPL code as a starting
point. I'm not sure what that was not originally done through the IETF --
possibly because there are so many different OS implementations of xattrs
with different semantics (some of which are slight).
There are also several proprietary NFSv3 xattr implementations out there
across various OSs -- it would be useful to provide users of these an
open, maintained option, as well as a pathway to NFSv4.
Given that there are disparate proprietary NFSv3 xattr implementations
how do you plan to ensure interoperability without a protocol
specification or at least an RPCL definition? Is interoperability even
practical at this point?
You say "it would be useful to provide users of these an open,
maintained option" but so far, security labels appear to be the only
specific use case you've mentioned. What other interesting applications
of xattrs would be useful to expose via NFS?
Before you go too much farther, you should justify the need to enhance a
closed standard like NFSv3 rather than expanding on NFSv4 for your purposes.
Since NFSv4 already has a lot of what is needed, it seems like you'd just need
a couple of changes in order to support name/value pairs.
As mentioned, I don't think the NFSv3 NAs are a good match to the
Linux/BSD xattr semantics.
e.g. what happens if a client creates a named attribute called
"system.posix_acl_access" ?
My reading of the spec is that a compliant server implementation would
have to allow this, from any user-level client application, without
interpretation of the NA itself.
If this is is the case, then it would clash with our ACL mechanism, which
uses xattrs locally for storage, with system-level interpretation and
mediation.
You would have a shot at actually making this an internet standard.
I think this community would prefer to advance reasons for users to adopt
NFSv4, rather than tie users even more to NFSv3.
There are two main drivers for this NFSv3 work.
One is to simply provide xattr support over NFS for Linux (and possibly
FreeBSD), given that it xattrs are a common filesystem feature and that
many people are still using NFSv3.
Since I started this work last year, more people do seem to be using NFSv4
(it seems to be the default for some distros now). I'd be interested if
anyone has figures or informed guesses on NFSv4 adoption -- certainly, if
NFSv3 is going to effectively disappear soon, it affects the rationale for
this work.
Assume that NFSv4 will be the dominant deployed NFS version at some
point in the future. We can't really say when that will be. We also
know there are still active NFSv2 deployments, which suggests NFSv3
won't be going away soon.
But the salient point, I think, is that if NFSv4 supports security
labels, then those who require this feature will upgrade, independent of
the broader adoption rate of NFSv4.
The other driver is the integration of MAC security into general purpose
OSs. SELinux and Smack extend Unix inode security metadata with MAC
labels implemented as xattrs. There is currently no way to convey these
labels over NFS, as there is no support for xattrs in the NFS protocol.
There is effort underway for NFSv4 in this area, designed around the full
security requirements of networked MAC labeling (Labeled NFS). This
is a far more comprehensive effort, and obviously does not provide a
solution for NFSv3 users.
Having a design document would allow wider public assessment of whether
there will be transition issues for users between your proposed NFSv3
xattr protocol and the labeled NFS work. Do you have a published
analysis of how NFSv3 xattr users would transition to NFSv4 labeled NFS?
With this NFSv3 xattr code, we are able to provide useful partial support
for MAC security labeling, for the scenario where the server simply stores
security labels without interpreting them. This allows clients to perform
fine-grained security labeling over NFSv3, and enforce policy locally.
Given that NFSv3 deployments overwhelmingly use AUTH_SYS authentication
and do not use wire encryption, how do you guarantee that xattrs aren't
modified during transit between server and client?
Again, having an RFC-like document that discusses NFS on-the-wire
authentication and integrity requirements for xattrs and security labels
would be useful to hammer out and verify implementation requirements.
There is considerable demand for NFS security labeling from users.
They've been deploying MAC security in production for several years now
but have always had to limit what they do regarding NFS. This would
provide a useful partial solution for these users via NFSv3, as an
intermediate step towards adopting NFSv4 and Labeled NFS.
To play devil's advocate for a moment, what's the practical difference
between not having support for security labels now, and having it
sometime in the near future with NFSv4?
One currently pressing use-case is where systems are deployed in VMs with
remote filesystems. It becomes very problematic to deploy security
schemes such as sVirt in this manner without fine-grained security
labeling, hindering attempts to take advantage of its security benefits
(see the notes on page 4 of the Atsec virt comparison study [1]).
Another more general case is simply being able to use NFS and MAC security
at the same time. A significant majority of Fedora users have SELinux
enabled [2], for example. If they want to deploy NFS home directories,
they either lose fine-grained security labeling there or disable security
entirely. In other words, lack of NFS support is hindering security
adoption.
Understood.
I would not see this as tying people in to NFSv3, rather, providing useful
functionality until they adopt NFSv4 with all of these features supported.
The NFSv4 LNFS effort will provide a more complete solution for security
labeling, and is being worked on in parallel, but it is not clear how long
the IETF processes for the various aspects of that project will take.
This gives NFSv3 users one more excuse not to upgrade (or simply to
postpone an upgrade even further). We want to encourage people to adopt
NFSv4. Security label support would be a compelling reason to upgrade.
I don't think you need to have a lot of concern about the IETF process.
Once there is rough consensus, you can proceed with a Linux prototype.
In summary, the benefits are:
- General xattr support for Linux NFSv3 users, and possibly for compatible
OSs such as FreeBSD
- Storage of security labels over NFSv3 for users deploying Linux MAC
security schemes (SELinux and Smack)
These objectives can be met relatively simply and quickly with this XATTR
protocol, which has precedents in the Linux ACL work and in existing NFSv3
xattr implementations.
To be clear, I'm not objecting to this work, but rather to understand
the big picture. Naturally RH can include this feature in their
products, and the NFS maintainers can decide they'll include NFSv3 xattr
support anyway, regardless of my concerns. And if the only purpose of
your post was for review before including it in RH products, then you
might ignore the following concerns.
However, since we're talking about more than a few lines of code and a
rather limited lifetime of usefulness, I think that before upstream
considers accepting this new side band protocol, there are larger issues
than whether it works today between two Linux systems, and avoids crashing.
o Do we understand the use cases for xattr over NFSv3?
o Do we understand the interoperability requirements?
o Will NFSv3's known security issues prevent this from being
ultimately useful?
o Is the work to support this feature upstream worth the year or two
it will be useful before NFSv4 labels are available?
o Are there other near term solutions?
o How do we ensure this implementation continues to meet its
specified requirements over time (ie is there a protocol spec? how will
implementations be tested)?
I think you should consider some next steps:
o Talk with other O/S and NFS server implementers who have xattrs to
see if there are real interoperability concerns
o Produce an RPCL and a design document
o Find other compelling use cases for exposing xattrs to NFS clients
o Tie into the labeled NFS work to see whether a Linux prototype on
NFSv4 at this time would be useful
o Consider proposing xattr support in NFSv4 to the NFSv4 working group
And if you want to consider some specific mechanical items:
o Use the page cache instead of the RPC buffer for storing xattrs
during RPC operations
o Get an RPC program number from IANA
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
