On 06/07/2010 06:40 PM, Kevin Constantine wrote: > When an export is freshly mounted, /proc/self/mountstats displays age = 0. > This causes nfs-iostat.py to divide by zero throwing an error. When we > have age = 0, other stats are greater than 0, so we'll set age = 1 and > print the relevant stats. > > Signed-off-by: Kevin Constantine <kevin.constantine@xxxxxxxxxxxxxxxxxxx> > --- > tools/nfs-iostat/nfs-iostat.py | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/tools/nfs-iostat/nfs-iostat.py b/tools/nfs-iostat/nfs-iostat.py > index 2d0b143..1207674 100644 > --- a/tools/nfs-iostat/nfs-iostat.py > +++ b/tools/nfs-iostat/nfs-iostat.py > @@ -366,6 +366,12 @@ class DeviceData: > sends = float(self.__rpc_data['rpcsends']) > if sample_time == 0: > sample_time = float(self.__nfs_data['age']) > + # sample_time could still be zero if the export was just mounted. > + # Set it to 1 to avoid divide by zero errors in this case since we'll > + # likely still have relevant mount statistics to show. > + # > + if sample_time == 0: > + sample_time = 1; > if sends != 0: > backlog = (float(self.__rpc_data['backlogutil']) / sends) / sample_time > else: Committed.. steved. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
