This was apparently dropped by mistake back in: efeeb16 pnfsd: set_device_notify Signed-off-by: Benny Halevy <bhalevy@xxxxxxxxxxx> --- fs/nfsd/nfs4xdr.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c index b61fb05..225023c 100644 --- a/fs/nfsd/nfs4xdr.c +++ b/fs/nfsd/nfs4xdr.c @@ -3434,8 +3434,8 @@ nfsd4_encode_getdevinfo(struct nfsd4_compoundres *resp, __be32 nfserr, nfserr = sb->s_pnfs_op->get_device_info(sb, &xdr, gdev->gd_layout_type, &gdev->gd_devid); - if (nfserr) { - } + if (nfserr) + goto err; /* The file system should never write 0 bytes without * returning an error -- 1.6.4.4 -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html