On 2010-06-08 10:30, Christoph Hellwig wrote:
> On Mon, Jun 07, 2010 at 02:11:47PM -0700, Alexandros Batsakis wrote:
>> +static inline void lock_current_layout(struct nfs_inode *nfsi)
>> +{
>> + spin_lock(&nfsi->lo_lock);
>> +}
>> +
>> +static inline void unlock_current_layout(struct nfs_inode *nfsi)
>> +{
>> + BUG_ON_UNLOCKED_LO((&nfsi->layout));
>> + spin_unlock(&nfsi->lo_lock);
>> +}
>
> Adding wrappers for these is nothing but obsfucation. No need
> for the BUG_ON above, the spinlock code asserts that already if
> building with spinlock debugging.
Good point.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
