We were just noticing that the pnfs/gfs2 code stores the data server list as a comma-delimited string of ip addresses. That string is passed from userspace without any validation--as far as I can tell, if the adminstrator passes in random data, that random data will get handed to the client as is. It would be better to validate that data when it's written to the /proc/fs/nfsd/ file--if for no other reason than to give administrators better error messages. While we're at it: should we just store the thing as a list of sockaddr's instead of as a string? I figure that would: - guarantee we never forget to validate the input; and - be more useful if we eventually use them as addresses in the kernel (e.g. for MDS<->DS protocol; does anyone have a prototype design for that?). But it means some more work converting back and forth (since getdeviceinfo still needs the addresses as strings). --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
