On 06/02/2010 06:54 PM, andros@xxxxxxxxxx wrote:
> From: Andy Adamson <andros@xxxxxxxxxx>
>
> pnfs_layoutcommit_inode prints its status upon exit.
>
> Signed-off-by: Andy Adamson <andros@xxxxxxxxxx>
> ---
> fs/nfs/pnfs.c | 11 ++---------
> 1 files changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
> index def27f8..91e944a 100644
> --- a/fs/nfs/pnfs.c
> +++ b/fs/nfs/pnfs.c
> @@ -766,15 +766,8 @@ _pnfs_return_layout(struct inode *ino, struct nfs4_pnfs_layout_segment *range,
> !pnfs_return_layout_barrier(nfsi, &arg));
> }
>
> - if (layoutcommit_needed(nfsi)) {
> - status = pnfs_layoutcommit_inode(ino, wait);
> - if (status) {
> - dprintk("%s: layoutcommit failed, status=%d. "
> - "Returning layout anyway\n",
> - __func__, status);
> - status = 0;
> - }
> - }
> + if (layoutcommit_needed(nfsi))
> + pnfs_layoutcommit_inode(ino, wait);
The print was not for the fail but for the status ignored by
layout_return. But ye we can do with out.
But please leave a big comment why we ignore the status from
pnfs_layoutcommit_inode.
Boaz
> }
> send_return:
> status = return_layout(ino, &arg, stateid, type, lo, wait);
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
