On Tue, Jun 01, 2010 at 09:59:18PM +0200, Christoph Hellwig wrote: > The conversion of write_inode_now calls to commit_metadata in commit > f501912a35c02eadc55ca9396ece55fe36f785d0 missed out the call in nfsd_setattr. > > But without this conversion we can't guarantee that a SETATTR request > has actually been commited to disk with XFS, which causes a regression > from 2.6.32 (only for NFSv2, but anyway). Got it, thanks. --b. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > Index: linux-2.6/fs/nfsd/vfs.c > =================================================================== > --- linux-2.6.orig/fs/nfsd/vfs.c 2010-06-01 21:24:34.945004695 +0200 > +++ linux-2.6/fs/nfsd/vfs.c 2010-06-01 21:25:48.299003856 +0200 > @@ -443,8 +443,7 @@ nfsd_setattr(struct svc_rqst *rqstp, str > if (size_change) > put_write_access(inode); > if (!err) > - if (EX_ISSYNC(fhp->fh_export)) > - write_inode_now(inode, 1); > + commit_metadata(fhp); > out: > return err; > > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
