On Wed, 2010-05-26 at 13:22 +0100, David Howells wrote: > Hi Trond, > > nfs_access_cache_shrinker() incurs the attached lockdep warning and then locks > up. > > Specifically, the problem appears to be the: > > spin_lock(&inode->i_lock); > > in the loop, for which there's not an unlock. Nor is there an unlock in > nfs_access_free_list() or nfs_access_free_entry. > > Is the spin_unlock() supposed to occur at the end of the loop, just before the > closing brace? Or did you mean to defer the unlock to nfs_access_free_entry()? Oh, crap... That's a typo in commit 9c7e7e23371e629dbb3b341610a418cdf1c19d91. I did not intend to remove the spin_unlock(&inode->i_lock) line. Thanks for spotting that! Trond -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
