On Mon, May 24, 2010 at 9:43 PM, William A. (Andy) Adamson <androsadamson@xxxxxxxxx> wrote: > On Mon, May 24, 2010 at 2:37 AM, Tao Guo <glorioustao@xxxxxxxxx> wrote: >> I see... But what if sync == 1? At that time, data must have already >> been freed, so you should not use data->cred anymore. > > Agreed. > > Since LAYOUTCOMMIT is not called after close, we can get rid of taking > the reference all together since a reference is taken on OPEN and > dropped on CLOSE. > > -->Andy I agree. However that will change several functions' interface I guess. I still have a question: why some procedures need to set rpc_cred whereas some needn't ? what is the connection between ctx's rpc_cred and nfs4_state_owner's so_cred? Any guidance will be appreciated... >> >> -- >> tao. >> > -- tao. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
