Re: [PATCH] sunrpc: fix leak on error on socket xprt setup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 21, 2010 at 09:16:19AM -0400, Trond Myklebust wrote:
> On Thu, 2010-05-20 at 20:25 -0400, J. Bruce Fields wrote: 
> > From: J. Bruce Fields <bfields@xxxxxxxxxxxxxx>
> > 
> > Also collect exit code together while we're at it.
> > 
> > Signed-off-by: J. Bruce Fields <bfields@xxxxxxxxxxxxxx>
> > Cc: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx>
> > ---
> >  net/sunrpc/xprtsock.c |   29 ++++++++++++++++++-----------
> >  1 files changed, 18 insertions(+), 11 deletions(-)
> > 
> > I think I sent this before, but it must have fallen through the cracks.
> 
> The patch doesn't really ring a bell, but it looks correct. On the other
> hand, this doesn't look like a bug we'd ever hit in practice,

... and even if we do, the consequences aren't much.

> so I'll
> probably delay merging it until I've got a few more critical bugfixes
> queued up.

I'd've probably left it to the next merge window.

> Unless, of course, you'd prefer to merge it yourself?

No preference; if you're in no hurry I'd just add it to my for-2.6.36
branch with your ack.

--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux