On Thu, May 20, 2010 at 8:57 PM, Trond Myklebust <trond.myklebust@xxxxxxxxxx> wrote: > On Thu, 2010-05-20 at 13:42 +0800, Tao Guo wrote: >> Unlock clp->cl_lock before taking inode->i_lock when setting up >> delegation to avoid possible deadlock bug. > > What deadlock? inode->i_lock should always be the innermost lock, so it > should always be safe to take it while already holding the nfs_client > lock. here is: http://marc.info/?l=linux-nfs&m=127424502009958&w=2 > > If somebody is taking the nfs_client lock while holding the inode lock, > then that would be the deadlock bug that needs to be fixed. > mm, I will reconsider that carefully~ > Trond > > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- tao. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
