Re: [PATCH] pnfsblock: Lookup list entry of layouts and tags in reverse order

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, Fields
I used the connectathon general test with my latest code, and it
passed the tests.
Can you just try the two patches I have sent in the mailing list to
see if it helps?

On Thu, May 20, 2010 at 5:38 AM, J. Bruce Fields <bfields@xxxxxxxxxxxx> wrote:
> On Wed, May 19, 2010 at 12:36:32PM -0400, J. Bruce Fields wrote:
>> On Wed, May 19, 2010 at 12:56:42PM +0800, Tao Guo wrote:
>> > I think the warning just indicate a possible bug:
>> > nfs_inode_set_delegation():
>> >                                         clp->cl_lock
>> >                                             --> inode->i_lock
>> > get_lock_alloc_layout():
>> >                                    nfsi->lo_lock
>> >                                       --> clp->cl_lock
>> > nfs_try_to_update_request()->pnfs_do_flush()->_pnfs_do_flush()->
>> > pnfs_find_get_lseg()->get_lock_current_layout():
>> >
>> > inode->i_lock
>> >
>> > -->nfsi->lo_lock
>> > In nfs_inode_set_delegation(), maybe we should unlock clp->cl_lock before
>> > taking inode->i_lock spinlock?
>> >
>> > PS: I just use the latest pnfsblock code(pnfs-all-2.6.34-2010-05-17) doing some
>> > basic r/w tests and it works fine.
>>
>> Could you try running the connectathon general test?
>>
>> > Can you find out which code path
>> > lead to IO errror?
>>
>> I'll try to narrow down the test case.
>
> I haven't gotten the chance to narrow it down any more.  So all I can
> say is that:
>
>        ~/cthon04# NFSTESTDIR=/mnt/TMP ./runtests -g
>
>        GENERAL TESTS: directory /mnt/TMP
>        if test ! -x runtests; then chmod a+x runtests; fi
>        cd /mnt/TMP; rm -f Makefile runtests runtests.wrk *.sh *.c
>        mkdummy rmdummy nroff.in makefile.tst
>        cp Makefile runtests runtests.wrk *.sh *.c mkdummy rmdummy
>        nroff.in makefile.tst /mnt/TMP
>
>        Small Compile
>        runtests.wrk: 63: ./stat: Input/output error
>        general tests failed
>
> is a consistent result for me.  (Using the tests from
> http://www.connectathon.org/nfstests.html.)
>
> --b.
>



-- 
tao.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux