On Thu, Apr 22, 2010 at 11:30:59AM +0200, Dan Carpenter wrote: > We "goto finish" from several places where "exp" is an ERR_PTR. Also I > changed the check for "fsid_key" so that it was consistent with the check > I added. OK, thanks; applied. --b. > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > > diff --git a/fs/nfsd/export.c b/fs/nfsd/export.c > index 872a5ef..bfe6f3f 100644 > --- a/fs/nfsd/export.c > +++ b/fs/nfsd/export.c > @@ -1071,9 +1071,9 @@ exp_export(struct nfsctl_export *nxp) > err = 0; > finish: > kfree(new.ex_pathname); > - if (exp) > + if (!IS_ERR_OR_NULL(exp)) > exp_put(exp); > - if (fsid_key && !IS_ERR(fsid_key)) > + if (!IS_ERR_OR_NULL(fsid_key)) > cache_put(&fsid_key->h, &svc_expkey_cache); > path_put(&path); > out_put_clp: -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
