Hey Kevin, On 04/14/2010 03:58 PM, Kevin Coffman wrote: > > The global krb5_enctypes array was used when the list was being read > once from a file. With the list now coming up with each request in > the updated upcall, I think the list obtained in the upcall should be > added to the clnt_info structure and then passed to the > limit_krb5_enctypes function as a parameter. I took a look at move the krb5_enctypes array in to the clnt_info structure and I'm thinking it might be better to keep it as global variable. Here is my reasoning... The "enctypes=" string that comes up in the upcall is basically a static string. Yeah I know it could change but that's highly unlikely any time soon. So if we put the krb5_enctypes array in the clnt_info structure we would have to parse that (static) string on *every* upcall, since the clnt_info structures are dynamically allocated. So parsing a static string on every upcall does not make sense to me. Keeping the supported enctypes in a global variable allow us to parse the string once and when it changes (which will never happen dynamically). So if the first enctypes values are cached, all that parsing become a simple strcmp()... ala: +parse_enctypes(char *enctypes) +{ + int n = 0; + char *curr, *comma; + int i; + static char *cached_types; + + if (cached_types && strcmp(cached_types, enctypes) == 0) + return 0; Makes sense? Am I missing something?? steved. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html