On Thu, Mar 11, 2010 at 02:08:10PM -0800, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> From: Li Zefan <lizf@xxxxxxxxxxxxxx>
>
> Don't forget to release the module refcnt if seq_open() returns failure.
Thanks, applied for 2.6.35.--b.
>
> Signed-off-by: Li Zefan <lizf@xxxxxxxxxxxxxx>
> Cc: J. Bruce Fields <bfields@xxxxxxxxxxxx>
> Cc: Neil Brown <neilb@xxxxxxx>
> Cc: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
>
> net/sunrpc/cache.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff -puN net/sunrpc/cache.c~sunrpc-cache-fix-module-refcnt-leak-in-a-failure-path net/sunrpc/cache.c
> --- a/net/sunrpc/cache.c~sunrpc-cache-fix-module-refcnt-leak-in-a-failure-path
> +++ a/net/sunrpc/cache.c
> @@ -1233,8 +1233,10 @@ static int content_open(struct inode *in
> if (!cd || !try_module_get(cd->owner))
> return -EACCES;
> han = __seq_open_private(file, &cache_content_op, sizeof(*han));
> - if (han == NULL)
> + if (han == NULL) {
> + module_put(cd->owner);
> return -ENOMEM;
> + }
>
> han->cd = cd;
> return 0;
> _
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
