Re: [PATCH] NFS: don't try to decode GETATTR if DELEGRETURN returned error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2010-03-21 at 07:17 -0400, Jeff Layton wrote: 
> The reply parsing code attempts to decode the GETATTR response even if
> the DELEGRETURN portion of the compound returned an error. The GETATTR
> response won't actually exist if that's the case and we're asking the
> parser to read past the end of the response.
> 
> This bug is fairly benign. The parser catches this without reading past
> the end of the response and decode_getfattr returns -EIO. Earlier
> kernels however had decode_op_hdr using the READ_BUF macro, and this
> bug would make this printk pop any time the client got an error from
> a delegreturn:
> 
> kernel: decode_op_hdr: reply buffer overflowed in line XXXX
> 
> More recent kernels seem to have replaced this printk with a dprintk.
> 
> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>

Applied. Thanks!

Trond
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux