Trond Myklebust <Trond.Myklebust@xxxxxxxxxx> wrote: > > The lock is probably held here, in which case something like the > > following would work well without needing the artificial rcu_read_lock() > > and rcu_read_unlock(): > > No. The lock is not held here. At this point, the delegation has been > detached from the inode that pointed to it, and so we can free up its > contents. > > We still need the call_rcu() to free up the allocated memory in order to > ensure that some process doing lockless traversal of the > clp->cl_delegations list doesn't crash. In that case, surely you can't detach the credentials pointer until the callback is invoked? David -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
