[PATCH 0/2] sunrpc: use monotonic time for expiry times

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I've always known I would pay for this some day ....

The authentication cache uses wall-clock time for expiry times and
related time stamps.

This can cause problems if the wall-clock time changes suddenly.
e.g. if you set the time forward one hour, the export cache is
immediately flushed.  This isn't an enormous problem, but it should be
fixed.

Currently, it can cause clients to have to resend requests which can
cause a delay of several timeouts.  Once we get the improvements in
which allow a thread to wait for a while rather than dropping a
request, this will be less of an issue.  But I think it is worth
fixing anyway.

So: two patches.  One moves come common code to an inline, the other
makes the change.

comments?

Thanks,
NeilBrown

---

NeilBrown (2):
      sunrpc: extract some common sunrpc_cache code from nfsd
      sunrpc: use monotonic time in expiry cache


 fs/nfs/dns_resolve.c         |    6 +++---
 fs/nfsd/export.c             |    9 +++------
 fs/nfsd/nfs4idmap.c          |    2 +-
 include/linux/sunrpc/cache.h |   23 ++++++++++++++++++++++-
 net/sunrpc/cache.c           |   33 ++++++++++++++++++---------------
 5 files changed, 47 insertions(+), 26 deletions(-)


--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux