[PATCH 0/2] Reduce GETATTRs during direct I/O

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Trond-

I mentioned this one to you last week.  I found that the NFS direct
I/O engine appears to be missing calls to nfs_fattr_init().  Please
take a look at these two patches and let me know if they look
reasonable for 2.6.34.

The problem also appears in the enterprise linux kernels.  We're still
testing this on EL4 and EL5 in specific.  We haven't found evidence so
far of incorrect behavior after applying the direct.c fix.  A bugzilla
report is forthcoming.

I haven't convinced myself that the extra GETATTR when opening an
O_DIRECT file is ever necessary.  But, I coded up a patch to your
specifications that changes O_DIRECT opens to avoid a GETATTR when
possible.

---

Chuck Lever (2):
      NFS: Don't generate a GETATTR when opening an O_DIRECT file
      NFS: Too many GETATTR and ACCESS calls after direct I/O


 fs/nfs/dir.c    |   20 ++++++++++++++++----
 fs/nfs/direct.c |    3 +++
 2 files changed, 19 insertions(+), 4 deletions(-)

-- 
Chuck Lever
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux