> -static struct svc_expkey *svc_expkey_update(struct svc_expkey *new, struct svc_expkey *old); > +static struct svc_expkey *svc_expkey_update(struct svc_expkey *new, > + struct svc_expkey *old); how is this an improvement ? I don't find the 2nd more more readable also, are you planning to do real changes to this file? If not, I would suggest not doing cleanups like this; while cleanups like the other things you did are fine as a first step to doing real work on a file, it's usually not liked very much to ONLY do such cosmetic things... -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html