On Wed, 2010-01-27 at 17:22 -0500, Chuck Lever wrote: > Hi- > > nfs_file_splice_write() accounts for the bytes in the request in the > "normal bytes written" counter, but nfs_file_splice_read() does not > account for bytes read. > > Should the read path count these as normal bytes as well, or should > the write path not account for these bytes? > nfs_file_splice_read() should probably update NFSIOS_NORMALREADBYTES. That said, why do nfs_file_read(), nfs_file_write() and nfs_file_splice_write() update the stats with the requested number of bytes, irrespective of the number of bytes that were actually read/write? Trond -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html