This is really a sunrpc-level function, and in later patches we'll need to call this routine from lockd as well. Move it to the sunrpc module, rename and export it. Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx> --- fs/nfs/sysfs.c | 19 ++++--------------- include/linux/sunrpc/sched.h | 1 + net/sunrpc/clnt.c | 12 ++++++++++++ 3 files changed, 17 insertions(+), 15 deletions(-) diff --git a/fs/nfs/sysfs.c b/fs/nfs/sysfs.c index 7b59a40d40c061a41b0fbde91aa006314f02c1fb..c29c5fd639554461bdcd9ff612726194910d85b5 100644 --- a/fs/nfs/sysfs.c +++ b/fs/nfs/sysfs.c @@ -217,17 +217,6 @@ void nfs_netns_sysfs_destroy(struct nfs_net *netns) } } -static bool shutdown_match_client(const struct rpc_task *task, const void *data) -{ - return true; -} - -static void shutdown_client(struct rpc_clnt *clnt) -{ - clnt->cl_shutdown = 1; - rpc_cancel_tasks(clnt, -EIO, shutdown_match_client, NULL); -} - static ssize_t shutdown_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf) @@ -258,14 +247,14 @@ shutdown_store(struct kobject *kobj, struct kobj_attribute *attr, goto out; server->flags |= NFS_MOUNT_SHUTDOWN; - shutdown_client(server->client); - shutdown_client(server->nfs_client->cl_rpcclient); + rpc_clnt_shutdown(server->client); + rpc_clnt_shutdown(server->nfs_client->cl_rpcclient); if (!IS_ERR(server->client_acl)) - shutdown_client(server->client_acl); + rpc_clnt_shutdown(server->client_acl); if (server->nlm_host) - shutdown_client(server->nlm_host->h_rpcclnt); + rpc_clnt_shutdown(server->nlm_host->h_rpcclnt); out: return count; } diff --git a/include/linux/sunrpc/sched.h b/include/linux/sunrpc/sched.h index eac57914dcf3200c1a6ed39ab030e3fe8b4da3e1..fe7c39a17ce44ec68c0cf057133d0f8e7f0ae797 100644 --- a/include/linux/sunrpc/sched.h +++ b/include/linux/sunrpc/sched.h @@ -232,6 +232,7 @@ unsigned long rpc_cancel_tasks(struct rpc_clnt *clnt, int error, bool (*fnmatch)(const struct rpc_task *, const void *), const void *data); +void rpc_clnt_shutdown(struct rpc_clnt *clnt); void rpc_execute(struct rpc_task *); void rpc_init_priority_wait_queue(struct rpc_wait_queue *, const char *); void rpc_init_wait_queue(struct rpc_wait_queue *, const char *); diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c index 2fe88ea79a70c134e58abfb03fca230883eddf1f..0028858b12d97e7b45f4c24cfbd761ba2a734b32 100644 --- a/net/sunrpc/clnt.c +++ b/net/sunrpc/clnt.c @@ -934,6 +934,18 @@ unsigned long rpc_cancel_tasks(struct rpc_clnt *clnt, int error, } EXPORT_SYMBOL_GPL(rpc_cancel_tasks); +static bool shutdown_match_client(const struct rpc_task *task, const void *data) +{ + return true; +} + +void rpc_clnt_shutdown(struct rpc_clnt *clnt) +{ + clnt->cl_shutdown = 1; + rpc_cancel_tasks(clnt, -EIO, shutdown_match_client, NULL); +} +EXPORT_SYMBOL_GPL(rpc_clnt_shutdown); + static int rpc_clnt_disconnect_xprt(struct rpc_clnt *clnt, struct rpc_xprt *xprt, void *dummy) { -- 2.48.1