On Tue, Mar 04, 2025 at 08:09:35PM +0800, Yunsheng Lin wrote: > On 2025/3/4 16:18, Dave Chinner wrote: > > ... > > > > >> > >> 1. https://lore.kernel.org/all/bd8c2f5c-464d-44ab-b607-390a87ea4cd5@xxxxxxxxxx/ > >> 2. https://lore.kernel.org/all/20250212092552.1779679-1-linyunsheng@xxxxxxxxxx/ > >> CC: Jesper Dangaard Brouer <hawk@xxxxxxxxxx> > >> CC: Luiz Capitulino <luizcap@xxxxxxxxxx> > >> CC: Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx> > >> CC: Dave Chinner <david@xxxxxxxxxxxxx> > >> CC: Chuck Lever <chuck.lever@xxxxxxxxxx> > >> Signed-off-by: Yunsheng Lin <linyunsheng@xxxxxxxxxx> > >> Acked-by: Jeff Layton <jlayton@xxxxxxxxxx> > >> --- > >> V2: > >> 1. Drop RFC tag and rebased on latest linux-next. > >> 2. Fix a compile error for xfs. > > > > And you still haven't tested the code changes to XFS, because > > this patch is also broken. > > I tested XFS using the below cmd and testcase, testing seems > to be working fine, or am I missing something obvious here > as I am not realy familiar with fs subsystem yet: That's hardly what I'd call a test. It barely touches the filesystem at all, and it is not exercising memory allocation failure paths at all. Go look up fstests and use that to test the filesystem changes you are making. You can use that to test btrfs and NFS, too. -Dave. -- Dave Chinner david@xxxxxxxxxxxxx
