On Thu, 2010-01-21 at 20:51 -0800, Alexandros Batsakis wrote:
> struct rpc_cred *nfs4_get_setclientid_cred(struct nfs_client *clp)
> @@ -878,7 +888,11 @@ void nfs4_schedule_state_manager(struct nfs_client *clp)
> if (test_and_set_bit(NFS4CLNT_MANAGER_RUNNING, &clp->cl_state) != 0)
> return;
> __module_get(THIS_MODULE);
> - atomic_inc(&clp->cl_count);
> + if (!atomic_inc_not_zero(&clp->cl_count)) {
> + nfs4_clear_state_manager_bit(clp);
> + module_put(THIS_MODULE);
> + return;
> + }
The use of atomic_inc_not_zero() should not be necessary here. Anybody
who is calling this function without holding a reference to clp is doing
something fundamentally wrong.
Trond
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
