On 12 Feb 2025, at 15:38, Anna Schumaker wrote: > Hi Ben, > > On Tue, Feb 11, 2025 at 12:32 PM Benjamin Coddington > <bcodding@xxxxxxxxxx> wrote: >> >> If the TLS handshake attempt returns -ETIMEDOUT, we currently translate >> that error into -EACCES. This becomes problematic for cases where the RPC >> layer is attempting to re-connect in paths that don't resonably handle >> -EACCES, for example: writeback. The RPC layer can handle -ETIMEDOUT quite >> well, however - so if the handshake returns this error let's just pass it >> along. > > Do you think it would be reasonable to add: > Fixes: 75eb6af7acdf ("SUNRPC: Add a TCP-with-TLS RPC transport class") > to this patch? Yes, that's probably reasonable. Thanks Anna, I should have added it. Ben