On 01/21/2010 04:37 PM, David Howells wrote: > Suresh Jayaraman <sjayaraman@xxxxxxx> wrote: > >> + if (!clp->fscache) >> + goto error_cleanup; > > This should be unnecessary. FS-Cache's API functions in linux/fscache.h > should handle a NULL cookie and do the right thing. > Also, while poking around the code, noticed that nfs_clear_inode() calls nfs_fscache_release_inode_cookie() which doesn't seem to check whether "fsc" mount option (i.e. NFS_FSCACHE(inode)) was used or not and goes ahead to call fscache_relinquish_cookie(). As I understand we should not be calling any fscache related functions when the client doesn't use fsc mount option (though CONFIG_NFS_FSCACHE is set), right? Thanks, -- Suresh Jayaraman -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
