On Thu, Jan 21, 2010 at 2:42 PM, Trond Myklebust
<Trond.Myklebust@xxxxxxxxxx> wrote:
> On Thu, 2010-01-21 at 14:19 -0500, andros@xxxxxxxxxx wrote:
>> From: Andy Adamson <andros@xxxxxxxxxx>
>>
>> Signed-off-by: Andy Adamson <andros@xxxxxxxxxx>
>> ---
>> fs/nfs/nfs4state.c | 7 +++++--
>> 1 files changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
>> index 069dcb3..c7f2944 100644
>> --- a/fs/nfs/nfs4state.c
>> +++ b/fs/nfs/nfs4state.c
>> @@ -1291,9 +1291,12 @@ static int nfs4_reset_session(struct nfs_client *clp)
>>
>> memset(clp->cl_session->sess_id.data, 0, NFS4_MAX_SESSIONID_LEN);
>> status = nfs4_proc_create_session(clp);
>> - if (status)
>> + if (status) {
>> status = nfs4_recovery_handle_error(clp, status);
>> -
>> + goto out;
>> + }
>> + /* create_session negotiated new slot table */
>> + clear_bit(NFS4CLNT_RECALL_SLOT, &clp->cl_state);
>> out:
>> /*
>> * Let the state manager reestablish state
>
> Errm.... Looking at nfs4_reset_session, wouldn't it make sense to move
> that 'out:' label down one line, so that we can get rid of that test for
> 'status == 0'?
yes indeed it would.
-->Andy
>
> Trond
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
