On 27 Jan 2025, at 16:50, Anna Schumaker wrote: > From: Anna Schumaker <anna.schumaker@xxxxxxxxxx> > > These are a handful of improvements that have been in the back of my > mind for a while. The first patch adds a (read-only) file to the NFS > client's sysfs collection to check the server's implementation id. The > remaining patches are on the sunrpc side. > > I did look into the 'nconnect' and 'max_connect' NFS client mount > options and how they interact with adding a new xprt in patch 4. My > reading is that 'nconnect' is just the initial number of connections > made by the NFS client during mounting. That shouldn't disallow adding a > new connection. The 'max_connect' parameter refers to the maximum number > of unique IP addresses in an xprt switch. The new connection I generate > is a clone of the main xprt, not a new address, so this doesn't come > into play either. So I'm convinced adding a new xprt is okay to do here. > > Thoughts? > Anna Looks great, one minor comment on 3/5. For series: Reviewed-by: Benjamin Coddington <bcodding@xxxxxxxxxx> Ben
