The comment explaining the need to recheck the devices list suggests that nfs mounts/unmounts may occur when automount is involved, but they can happen for other reasons as well. Make the comment explain the issue more broadly. Signed-off-by: Frank Sorenson <sorenson@xxxxxxxxxx> --- tools/nfs-iostat/nfs-iostat.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/nfs-iostat/nfs-iostat.py b/tools/nfs-iostat/nfs-iostat.py index 08b827c0..1502b431 100755 --- a/tools/nfs-iostat/nfs-iostat.py +++ b/tools/nfs-iostat/nfs-iostat.py @@ -631,8 +631,8 @@ client are listed. time.sleep(interval) sample_time = interval mountstats = parse_stats_file('/proc/self/mountstats') - # automount mountpoints add and drop, if automount is involved - # we need to recheck the devices list when reparsing + # nfs mountpoints may appear or disappear, so we need to + # recheck the devices list each time we parse mountstats devices = list_nfs_mounts(origdevices,mountstats) if len(devices) == 0: print('No NFS mount points were found') @@ -645,8 +645,8 @@ client are listed. time.sleep(interval) sample_time = interval mountstats = parse_stats_file('/proc/self/mountstats') - # automount mountpoints add and drop, if automount is involved - # we need to recheck the devices list when reparsing + # nfs mountpoints may appear or disappear, so we need to + # recheck the devices list each time we parse mountstats devices = list_nfs_mounts(origdevices,mountstats) if len(devices) == 0: print('No NFS mount points were found') -- 2.48.1