On Thu, 2010-01-14 at 15:38 -0700, H Hartley Sweeten wrote: > xprtsock.c: make bc_{malloc/free} static > > The server backchannel buf_alloc and buf_free methods should > be static since they are not used outside this file. > > Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx> > Cc: J. Bruce Fields <bfields@xxxxxxxxxxxx> > Cc: Neil Brown <neilb@xxxxxxx> > Cc: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx> > Cc: David S. Miller <davem@xxxxxxxxxxxxx> > > --- > > diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c > index 3d739e5..721bafd 100644 > --- a/net/sunrpc/xprtsock.c > +++ b/net/sunrpc/xprtsock.c > @@ -2100,7 +2100,7 @@ static void xs_tcp_print_stats(struct rpc_xprt *xprt, struct seq_file *seq) > * we allocate pages instead doing a kmalloc like rpc_malloc is because we want > * to use the server side send routines. > */ > -void *bc_malloc(struct rpc_task *task, size_t size) > +static void *bc_malloc(struct rpc_task *task, size_t size) > { > struct page *page; > struct rpc_buffer *buf; > @@ -2120,7 +2120,7 @@ void *bc_malloc(struct rpc_task *task, size_t size) > /* > * Free the space allocated in the bc_alloc routine > */ > -void bc_free(void *buffer) > +static void bc_free(void *buffer) > { > struct rpc_buffer *buf; > Thanks! I'll put this in the sunrpc-for-next branch. Trond -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html