On Tue, 10 Dec 2024, Jeff Layton wrote: > On Mon, 2024-12-09 at 12:27 -0500, Chuck Lever wrote: > > On 12/8/24 7:41 PM, NeilBrown wrote: > > > module_param(nsm_use_hostnames, bool, 0644); > > > -module_param(nlm_max_connections, uint, 0644); > > > > We've discussed deprecation and removal of items from /proc/fs/nfsd > > before, but removing a module parameter seems like it needs to be > > handled with the usual deprecation schedule? > > > > Yeah, that could break someone on an upgrade. What we should probably > do is keep the knob around, but just make it not do anything now, and > throw a pr_warn message or something if someone tries to set it. > Eventually in a year or two, we should be able to remove it. > What might break? modprobe or insmod won't have a problem. The kernel will emit nfsd: unknow parameter '...' ignored but that is not much more than a deprecation warning. echo 42 > /sys/modules/nfsd/parameters/nlm_max_connections will produce "permission denied" but is unlikely to abort a shell script (unless "-e" is used - which seems unlikely). I don't think there is a risk here. Thanks, NeilBrown
