On Fri, 6 Dec 2024 at 16:54, Chuck Lever <chuck.lever@xxxxxxxxxx> wrote: > > Hi Roland, thanks for posting. > > Here are some initial review comments to get the ball rolling. > > > On 12/6/24 5:54 AM, Roland Mainz wrote: > > Hi! > > > > ---- > > > > Below (and also available at https://nrubsig.kpaste.net/b37) is a > > patch which adds support for nfs://-URLs in mount.nfs4, as alternative > > to the traditional hostname:/path+-o port=<tcp-port> notation. > > > > * Main advantages are: > > - Single-line notation with the familiar URL syntax, which includes > > hostname, path *AND* TCP port number (last one is a common generator > > of *PAIN* with ISPs) in ONE string > > - Support for non-ASCII mount points, e.g. paths with CJKV (Chinese, > > s/mount points/export paths > > (When/if you need to repost, you should move this introductory text into > a cover letter.) > > > > Japanese, ...) characters, which is typically a big problem if you try > > to transfer such mount point information across email/chat/clipboard > > etc., which tends to mangle such characters to death (e.g. > > transliteration, adding of ZWSP or just '?'). > > - URL parameters are supported, providing support for future extensions > > IMO, any support for URL parameters should be dropped from this > patch and then added later when we know what the parameters look > like. Generally, we avoid adding extra code until we have actual > use cases. Keeps things simple and reduces technical debt and dead > code. > I think the minimum support Roland added (or what is left of it) should remain. It covers read-only ("ro=1") and read-write ("rw=1") attributes, which are clearly a property of the exported path. exportfs -U generates nfs URLs with "?ro=1" for read-only exports, and mount.nfs4 should treat such urls as the standard mandates, and not either drop an attribute (which is a violation of rfc 1738) or reject a mount request because support for "ro" parameter was dropped in this patch. ... > I wonder how distributions will test the ability to mount > percent-escaped path names, though. Maybe not upstream's problem. perl -MURI::Escape -e 'print URI::Escape::uri_escape($ARGV[0]) ; print "\n"' "money_€" money_%E2%82%AC I don't see that as a problem. Roland also has a patch for exportfs to add nfs url output with -U > > > - This feature will not be provided for NFSv3 > > Why shouldn't mount.nfs also support using an NFS URL to mount an > NFSv3-only server? Isn't this simply a matter of letting mount.nfs > negotiate down to NFSv3 if needed? NFSv3 is obsolete. Redhat support keeps telling us that for almost ten years now. Ced -- Cedric Blancher <cedric.blancher@xxxxxxxxx> [https://plus.google.com/u/0/+CedricBlancher/] Institute Pasteur
