On Fri, 06 Dec 2024, Jeff Layton wrote:
> On Fri, 2024-12-06 at 11:43 +1100, NeilBrown wrote:
> > diff --git a/fs/nfsd/xdr4.h b/fs/nfsd/xdr4.h
> > index 382cc1389396..c26ba86dbdfd 100644
> > --- a/fs/nfsd/xdr4.h
> > +++ b/fs/nfsd/xdr4.h
> > @@ -576,9 +576,7 @@ struct nfsd4_sequence {
> > u32 slotid; /* request/response */
> > u32 maxslots; /* request/response */
> > u32 cachethis; /* request */
> > -#if 0
> > u32 target_maxslots; /* response */
> > -#endif /* not yet */
> > u32 status_flags; /* response */
> > };
> >
>
>
> I don't see where the above "#if 0" gets removed in patch 6. Shouldn't
> it be?
You are misreading. It is being removed here in patch 5.
It was added in 2.6.38 in
Commit b85d4c01b76f ("nfsd41: sequence operation")
>
> While it makes for a larger patch, I think we'd be better served by
> squashing 5 and 6 together. It doesn't make sense to add this core
> infrastructure without something to call it.
I find it easier to review if the distinct elements of functionality are
kept separate. But if both you and Chuck want just one patch here, I
can do that.
Thanks,
NeilBrown
> --
> Jeff Layton <jlayton@xxxxxxxxxx>
>
