rsize/wsize chaos in heterogeneous environments Re: [PATCH] nfs(5): Update rsize/wsize options

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 11, 2024 at 8:25 AM Seiichi Ikarashi (Fujitsu)
<s.ikarashi@xxxxxxxxxxx> wrote:
>
> The rsize/wsize values are not multiples of 1024 but multiples of PAGE_SIZE
> or powers of 2 if < PAGE_SIZE as defined in fs/nfs/internal.h:nfs_io_size().

*facepalm*

How should this work at all in a heterogeneous environment where
pagesizes can be 4k or 64k (ARM)?

IMHO this is a BIG, rsize and wsize should count in 1024 bytes, and
warn if there is no exact match to a page size. Otherwise non-portable
chaos rules.

Sebi
-- 
Sebastian Feld - IT secruity expert





[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux