On Wed, 09 Oct 2024, Benjamin Coddington wrote: > On 9 Oct 2024, at 1:28, NeilBrown wrote: > > > xs_tcp_finish_connecting() can return -ENOTCONN but the switch statement > > in xs_tcp_setup_socket() treats that as an unhandled error. > > > > If we treat it as a known error it would propagate back to > > call_connect_status() which does handle that error code. This appears > > to be the intention of the commit (given below) which added -ENOTCONN as > > a return status for xs_tcp_finish_connecting(). > > > > So add -ENOTCONN to the switch statement as an error to pass through to > > the caller. > > > > Link: https://bugzilla.suse.com/show_bug.cgi?id=1231050 > > Link: https://access.redhat.com/discussions/3434091 > > Fixes: 01d37c428ae0 ("SUNRPC: xprt_connect() don't abort the task if the transport isn't bound") > > Signed-off-by: NeilBrown <neilb@xxxxxxx> > > Thanks! We should have chased this down ages ago.. > > Reviewed-by: Benjamin Coddington <bcodding@xxxxxxxxxx> Thanks Ben. Trond, Anna: have you had a chance to look at this yet? Thanks, NeilBrown
