On Mon, 28 Oct 2024, NeilBrown wrote: > On Mon, 28 Oct 2024, Chuck Lever wrote: > > > > > It might be nicer if these heuristics were eventually replaced by a > > shrinker. Maybe for another day. > > I don't think so. A shrinker is for freeing things that have already > been allocated. Here we want to predict whether future allocations will > succeed easily. If we pre-allocated space for all slots in the reply > cache, then a shrinker would be appropriate to reduce the > pre-allocation, but we don't do that and I don't think we want to. > Oh wait - we do pre-allocate. In alloc_session(). So we really need to be freeing some of those when we push the max_slot limit down. I need to revisit this patch. Thanks, NeilBrown
