> On Oct 24, 2024, at 11:00 PM, NeilBrown <neilb@xxxxxxx> wrote: > > I'm wondering about the request for a garbage-collected nfsd_file > though. For NFSv3 that makes sense. For NFSv4 we would expect the file > to already be open as a non-garbage-collected nfsd_file and opening it > again seems wasteful. That doesn't need to be fixed for this patch and > maybe doesn't need to be fixed at all, but it seemed worth highlighting. I don't think using a GC'd nfsd_file for LOCALIO is a bug. NFSv4 guarantees an OPEN to pin the nfsd_file, and a CLOSE (or lease expiry) to release it. There's no desire for or need for garbage collection. NFSv3 and LOCALIO use each nfsd_file for the life of one I/O operation, and that nfsd_file is cached in the expectation that another I/O operation on the same file will happen with frequent temporarl proximity. Garbage collection is needed for both cases. -- Chuck Lever
