On 10/8/24 4:12 PM, Benjamin Coddington wrote: > On 3 Oct 2024, at 11:14, Alexander Aring wrote: > >> Hi, >> >> I currently have pending patches for fs/dlm (Distributed Lock Manager) >> subsystem to introduce some helpers to udev. However, it seems it takes >> more time that I can bring those changes upstream. I put those out now >> and already figured out that nfs can also take advantage of those changes. >> >> With this patch-series I try to try to reduce my patch-series for DLM >> and already bring part of it upstream and nfs will be a user of it. >> >> The ownership callback, I think it should be set as the >> kset_create_and_add() sets this callback as default. I never had any >> issues with it, but there might be container corner cases that requires >> those changes? >> >> - Alex >> >> Alexander Aring (4): >> kobject: add kset_type_create_and_add() helper >> kobject: export generic helper ops >> nfs: sysfs: use kset_type_create_and_add() >> nfs: sysfs: use default get_ownership() callback >> >> fs/nfs/sysfs.c | 30 +++---------------- >> include/linux/kobject.h | 10 +++++-- >> lib/kobject.c | 65 ++++++++++++++++++++++++++++++----------- >> 3 files changed, 60 insertions(+), 45 deletions(-) >> >> -- >> 2.43.0 > > These look good to me, though patch 4/4 seems superfluous, I responded there. They look good to me, too. They're not really a bugfix, so they'll probably go in through v6.13 (assuming Trond has no objections, it's his turn to do the merge) and not v6.12-rc. Anna > > For the series: > Reviewed-by: Benjamin Coddington <bcodding@xxxxxxxxxx> > > Ben >
