Re: [PATCH] nfsd: Fix nfs4_disable_idmapping option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 13 Sep 2024, Pali Rohár wrote:
> NFSv4 server option nfs4_disable_idmapping says that it turn off server's
> NFSv4 idmapping when using 'sec=sys'. But it also turns idmapping off also
> for 'sec=none'.
> 
> NFSv4 client option nfs4_disable_idmapping says same thing and really it
> turns the NFSv4 idmapping only for 'sec=sys'.
> 
> Fix the NFSv4 server option nfs4_disable_idmapping to turn off idmapping
> only for 'sec=sys'. This aligns the server nfs4_disable_idmapping option
> with its description and also aligns behavior with the client option.

Why do you think this is the right approach?
If the documentation says "turn off when sec=sys" and the implementation
does "turn off when sec=sys or sec=none" then I agree that something
needs to be fixed.  I would suggest that the documentation should be
fixed.


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux