Hi, Another newbie question that hopefully someone won't mind answering.... There are a few functions in fs/nfs/nfs3acl.c (nfs3_prepare_get_acl(),...) that my patch uses for NFSv4. I just copied them into nfs42proc.c to get things to build, but that obviously is just a hack. So, the question is...what should I do with functions chared between the NFSv3 and NFSv4 clients? - Put them in some new file in fs/nfs_common, maybe? Thanks in advance for your help, rick ps: If you create a new file, do you just update the Makefile or is there more trickery involved?