On 2 Sep 2024, at 7:46, Yafang Shao wrote: > Hello Ben, > > Upon thorough examination, we have identified the root cause of the > issue to lie within the NFS server, specifically its behavior of > truncating file listings to match the client's READDIR RPC args->size > parameter without appropriately adjusting the cookie value. After > implementing a fix on the server side, the issue has been resolved. Nice work! Out of curiosity, what server implemenation did you fix? > However, to enhance resilience and mitigate future server-side > vulnerabilities, it may be prudent to implement client-side handling > mechanisms for such issues. What do you think? We have in the past modified the client to be more resilient, but usually only for cases where the server can cause the client to crash and/or corrupt data. For a bug like this, the maintainers usually assert "we do not fix the client for server bugs", since doing so can paper over protocol correctness issues created by the server. I think that's what would happen here if you keep working to justify your fix -- which you're free to do, of course! Regards, Ben
