On Fri, 30 Aug 2024 17:03:15 +1000, NeilBrown wrote:
> I've been digging into wake_up_bit and wake_up_var recently. There are
> a lot of places where the required barriers aren't quite right.
>
> This patch fixes them up for nfsd. The bugs are mostly minor, though
> the rp_locked on might be a credible problem on weakly ordered hosts
> (e.g. power64).
>
> [...]
Applied to nfsd-next for v6.12, thanks!
[1/2] nfsd: use clear_and_wake_up_bit()
commit: 2b9a19d16beda1b2ca5edab47d74b73d4d958b12
[2/2] nfsd: avoid races with wake_up_var()
commit: a2bf7d13821603fb90c3f6e695bd5fb4ee19de71
Both of these patches threw compilation errors. I corrected those
issues before applying. Please check my work.
checkpatch.pl complained about the lack of comment on the added
barriers. I felt the code was self-explanatory so made no change.
--
Chuck Lever
