On Sun, Dec 20, 2009 at 10:46:26AM +0100, Michael Guntsche wrote:
> I think I figured out the problem.
>
> Apparently the code checked if insecure was set, while it should check if it was NOT set.
Thanks! And apologies, I ran across this too a couple days ago, left it
in -next, and forgot to send it upstream.... I'll do that now.
--b.
>
> Kind regards,
> Michael
>
> diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c
> index 1c12177..55c8e63 100644
> --- a/fs/nfsd/nfsfh.c
> +++ b/fs/nfsd/nfsfh.c
> @@ -89,7 +89,7 @@ static __be32 nfsd_setuser_and_check_port(struct svc_rqst *rqstp,
> int flags = nfsexp_flags(rqstp, exp);
>
> /* Check if the request originated from a secure port. */
> - if (!rqstp->rq_secure && (flags & NFSEXP_INSECURE_PORT)) {
> + if (!rqstp->rq_secure && !(flags & NFSEXP_INSECURE_PORT)) {
> RPC_IFDEBUG(char buf[RPC_MAX_ADDRBUFLEN]);
> dprintk(KERN_WARNING
> "nfsd: request from insecure port %s!\n",
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
