On Fri, 16 Aug 2024, Jeff Layton wrote: > +// Generated by lkxdrgen, with hand-edits. I *really* don't like having code in the kernel that is partly tool-generated and partly human-generated, and where the boundary isn't obvious (like separate files). If we cannot use tool-generated code as-is, then let's fix the tool. If we cannot fix the tool, then include the raw output and a human-generated patch which the makefile combines. Ideally the tool should be in tools/, the .x file should be in fs/nfsd/ and the makefile should apply the one to the other. We are going to want to do that eventually and I think it should be priority. The tool doesn't have to be bug-free before it lands (nothing is). A particular reason for this is that I cannot review tool-generated hand-editted code. It is too noisy and I don't know which parts are worth closer inspection etc. Thanks, NeilBrown
