Re: [PATCH rfc 2/2] NFSD: allow client to use write delegation stateid for READ

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



nfsd4_encode_read_plus() needs to handle write delegation stateids
as well.

I'm not too sure about modifying the f_mode on an nfsd_file you
just got from a cache of shared nfsd_files.

I think I'd prefer if preprocess_stateid returned an nfsd_file that
was already open for read.

There would not be any nfsd_file that was already open for read since
the file still has a write delegation on it, unless the open for read
was from the same client.

I'm also not sure if a client would send an open for read to the server
when it already owned the write delegation of the file.

It doesn't have to, IIUC. So this needs to be addressed.
One thing that we could do is open the file for RW to begin with if we hand
out a write delegation?

BTW, the patch is missing the part that actually offers the write delegation,
which was sent initially.




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux