On Fri, Jul 19, 2024 at 02:55:53PM -0400, Jeff Layton wrote:
> When creating nfsd sockets via the netlink interface, we do want to
> register with the portmapper. Don't set SVC_SOCK_ANONYMOUS.
NFSD's RDMA transports don't register with rpcbind, for example.
> Fixes: 16a471177496 NFSD: add listener-{set,get} netlink command
> Reported-by: Steve Dickson <steved@xxxxxxxxxx>
> Cc: Lorenzo Bianconi <lorenzo@xxxxxxxxxx>
> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
> ---
> fs/nfsd/nfsctl.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
> index 9e0ea6fc2aa3..34eb2c2cbcde 100644
> --- a/fs/nfsd/nfsctl.c
> +++ b/fs/nfsd/nfsctl.c
> @@ -2069,8 +2069,7 @@ int nfsd_nl_listener_set_doit(struct sk_buff *skb, struct genl_info *info)
> continue;
> }
>
> - ret = svc_xprt_create_from_sa(serv, xcl_name, net, sa,
> - SVC_SOCK_ANONYMOUS,
> + ret = svc_xprt_create_from_sa(serv, xcl_name, net, sa, 0,
> get_current_cred());
> /* always save the latest error */
> if (ret < 0)
>
> ---
> base-commit: 769d20028f45a4f442cfe558a32faba357a7f5e2
> change-id: 20240719-nfsd-next-d9582a2c50c2
>
> Best regards,
> --
> Jeff Layton <jlayton@xxxxxxxxxx>
>
--
Chuck Lever
