On Thu, Jul 11, 2024 at 11:24:01AM -0400, Benjamin Coddington wrote:
> The GSS routine errors are values, not flags.
My reading of kernel and user space GSS code is that these are
indeed flags and can be combined. The definitions are found in
include/linux/sunrpc/gss_err.h:
To wit:
116 /*
117 * Routine errors:
118 */
119 #define GSS_S_BAD_MECH (((OM_uint32) 1ul) << GSS_C_ROUTINE_ERROR_OFFSET)
120 #define GSS_S_BAD_NAME (((OM_uint32) 2ul) << GSS_C_ROUTINE_ERROR_OFFSET)
....
> Signed-off-by: Benjamin Coddington <bcodding@xxxxxxxxxx>
> ---
> include/trace/events/rpcgss.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/trace/events/rpcgss.h b/include/trace/events/rpcgss.h
> index 7f0c1ceae726..b0b6300a0cab 100644
> --- a/include/trace/events/rpcgss.h
> +++ b/include/trace/events/rpcgss.h
> @@ -54,7 +54,7 @@ TRACE_DEFINE_ENUM(GSS_S_UNSEQ_TOKEN);
> TRACE_DEFINE_ENUM(GSS_S_GAP_TOKEN);
>
> #define show_gss_status(x) \
> - __print_flags(x, "|", \
> + __print_symbolic(x, \
> { GSS_S_BAD_MECH, "GSS_S_BAD_MECH" }, \
> { GSS_S_BAD_NAME, "GSS_S_BAD_NAME" }, \
> { GSS_S_BAD_NAMETYPE, "GSS_S_BAD_NAMETYPE" }, \
> --
> 2.44.0
>
>
--
Chuck Lever
