> On Jul 11, 2024, at 6:11 AM, Sagi Grimberg <sagi@xxxxxxxxxxx> wrote: > > On 11/07/2024 12:59, Dan Aloni wrote: >> It would be beneficial to implement handling similar to >> RDMA_CM_EVENT_DEVICE_REMOVAL in the case where RDMA_CM_EVENT_ADDR_CHANGE >> is issued for an unconnected CM. > > I think Chuck has a pending series for handling device removals with a dedicated > ib_client. So one would have to rebase against the other... > > See: https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.gittopic-device-removal > > Other than that, looks good, > Reviewed-by: Sagi Grimberg <sagi@xxxxxxxxxxx> FYI Anna has taken my "rpcrdma ib_client" series: http://git.linux-nfs.org/?p=anna/linux-nfs.git;a=shortlog;h=refs/heads/linux-next PATCH 1/2 "rpcrdma: fix handling for RDMA_CM_EVENT_DISCONNECTED due to address change" is a fix that you probably want to make available to the LTS kernels, so it would have to be applied before my patches in order to make that possible. I don't know what Anna's policy is regarding rearranging the patches in her linux-next branch. Quite possibly she'll just have to rip out my patches so we can give her a fresh series with your work and mine properly ordered. -- Chuck Lever
