On 2024-07-11 13:11:11, Sagi Grimberg wrote: > > > On 11/07/2024 12:59, Dan Aloni wrote: > > It would be beneficial to implement handling similar to > > RDMA_CM_EVENT_DEVICE_REMOVAL in the case where RDMA_CM_EVENT_ADDR_CHANGE > > is issued for an unconnected CM. > > I think Chuck has a pending series for handling device removals with a > dedicated > ib_client. So one would have to rebase against the other... > > See: https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.gittopic-device-removal > > Other than that, looks good, > Reviewed-by: Sagi Grimberg <sagi@xxxxxxxxxxx> I ran some testing with `device-removal` branch (merge fe4cef916d91 v6.10-rc7), and found that the `RDMA_CM_EVENT_ADDR_CHANGE` fix is still required and independent of the branch's content. And for the second patch I sent, which fixes only a theoretical issue, I think we need the `case RDMA_CM_EVENT_ADDR_CHANGE:` branch to implement the same logic like the removed `case RDMA_CM_EVENT_DEVICE_REMOVAL:` branch. -- Dan Aloni
