On Thu, Jun 20, 2024 at 06:36:05AM +0200, Christoph Hellwig wrote: > On Wed, Jun 19, 2024 at 01:39:32PM -0400, cel@xxxxxxxxxx wrote: > > if (IS_ERR(bdev_file)) { > > - pr_warn("pNFS: failed to open device %s (%ld)\n", > > + dprintk("failed to open device %s (%ld)\n", > > devname, PTR_ERR(bdev_file)); > > I'd just drop this one entirely. Actually I'd like to keep this dprintk because it displays the whole path to the device. That has diagnostic value, IMO. -- Chuck Lever